Links

pull_request_template

Every time a developer will make a pull request and a team-mate will review the work, the below points need to be checked!

Reviewee

  • PR Title = Ticket Title
  • Ticket link:
  • Visuals:
App Screenshot
UX Mock-up
  • Flow typed
  • Logic unit tested
  • Peer review
  • Show live feature to reviewer
  • Definition of done:
    • Android: Sony Experia SP
    • iOS: iPhone 6S iOS 10

Reviewer

  • Read and understand the ticket ("What" + "How")
  • No missing logic test
  • No missing flow typing
  • No missing refactoring